Closed sairam91 closed 5 days ago
Good start! A couple initial comments:
useEffect()
hooks need to incorporate it as a dependency. That means passing through the history
object to the affected components. Ideally, we'd use useQueryParams()
too, but when I tried that, the history.listen()
callback wouldn't fire. I think that's due to the interdependency with the workflowTemplates
/workflowParameters
props.ui/src/app/workflows/components/submit-workflow-panel.tsx
Here's a commit that does both things: https://github.com/MasonM/argo-workflows/commit/d2c11c87503c5054c9ce86d5a19918ed79f8cc24
@sairam91 Sorry for the delay. You mentioned you were going to fill out the "Verification" section of the PR, so I was waiting for that. If you're unsure of what to put there, I think this would work (you can copy-and-paste this):
make start UI=true
WorkflowTemplate
named with the default example
Also, it looks like there's conflicts. If you can add me as a collaborator at https://github.com/sairam91/argo-workflows/settings, I can resolve them for you, if you want.
Closed in favor of https://github.com/argoproj/argo-workflows/pull/13922
Fixes #12124
Motivation
This PR adds support for developers to prefil submit workflow form by passing in the values through query parameters.
To prefil a submit workflow developers can pass in the following query parameters
Modifications
workflow-list
componentsubmit-workflow-panel.tsx
component to default entry point if provided.workflow-creator.tsx
to read default values from query parameters.?parameters[key]=value
.Verification