search

argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

feat: include container name in error message. Fixes #10007 #13790

Closed tooptoop4 closed 2 weeks ago

tooptoop4 commented 1 month ago

Fixes https://github.com/argoproj/argo-workflows/issues/10007

tooptoop4 commented 4 weeks ago

docs test seems unrelated

agilgur5 commented 4 weeks ago

/retest

agilgur5 commented 4 weeks ago

/retest

Oh right, that only runs for ci-build.yaml. Manually retrigerred the Docs CI. Never seen that flake before though 🤔

agilgur5 commented 3 weeks ago

There are some libraries that consider errors as part of the API boundary, but we currently don't. This also isn't the first time we've changed an error.

with exact matching

Some libraries, like protobuf, even intentionally insert randomness to prevent you from doing exact matching like with https://github.com/argoproj/argo-workflows/pull/12737#issuecomment-1977948270 / https://github.com/prometheus/client_model/issues/83

tooptoop4 commented 3 weeks ago

I think this a breaking change, we better have a documentation for this. I can imagine there exist users using conditional retry with exact matching on message

added a note