argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

build(devcontainer): expose port of `mkdocs serve` #13811

Closed agilgur5 closed 3 weeks ago

agilgur5 commented 4 weeks ago

Follow-up to #13349, I missed the docs service

Motivation

port 8000 is normally used by mkdocs serve per its logs:

INFO    -  [18:34:01] Watching paths for changes: 'docs', 'mkdocs.yml'
INFO    -  [18:34:01] Serving on http://127.0.0.1:8000/

Modifications

Add port 8000 to the devcontainer.json#forwardPorts config

Verification

Notes to Reviewers

Note that like make docs, there is a make docs-serve task as well, which is referenced in the contributing docs