Closed agilgur5 closed 3 weeks ago
I couldn't request a review from @Adrien-D due to not being in the "members" team -- same reason as https://github.com/argoproj/argo-workflows/issues/8790#issuecomment-2412016304 -- so tagging in this comment instead
Added @Adrien-D
Follow-up to https://github.com/argoproj/argo-workflows/pull/12539 "Future Work" part 3, https://github.com/argoproj/argo-workflows/pull/13160#discussion_r1633495520, https://github.com/argoproj/argo-workflows/pull/11811#discussion_r1331813108, https://github.com/argoproj/argo-workflows/pull/13069#discussion_r1615360748, and other places I've mentioned it
Motivation
Automatically sort imports for consistent style, like Python's
isort
but for JS/TSModifications
using https://github.com/IanVS/prettier-plugin-sort-imports
yarn.lock
ran
yarn lint
and committed changesmanually fix https://github.com/argoproj/argo-workflows/pull/13343#discussion_r1792535276 and https://github.com/argoproj/argo-workflows/pull/13284#discussion_r1792538253 as those are unsortable since they were placed after side-effect imports
Verification
yarn lint
has no more changes, otherwise this is purely stylistic and has no semantic changesNotes to Reviewers
prettier
plugin instead of aneslint
plugin as there was less configurationprettier
is not quite zero config, but "low" config