argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

build(ui): automatically sort imports #13813

Closed agilgur5 closed 3 weeks ago

agilgur5 commented 4 weeks ago

Follow-up to https://github.com/argoproj/argo-workflows/pull/12539 "Future Work" part 3, https://github.com/argoproj/argo-workflows/pull/13160#discussion_r1633495520, https://github.com/argoproj/argo-workflows/pull/11811#discussion_r1331813108, https://github.com/argoproj/argo-workflows/pull/13069#discussion_r1615360748, and other places I've mentioned it

Motivation

Automatically sort imports for consistent style, like Python's isort but for JS/TS

Modifications

Verification

yarn lint has no more changes, otherwise this is purely stylistic and has no semantic changes

Notes to Reviewers

agilgur5 commented 4 weeks ago

I couldn't request a review from @Adrien-D due to not being in the "members" team -- same reason as https://github.com/argoproj/argo-workflows/issues/8790#issuecomment-2412016304 -- so tagging in this comment instead

terrytangyuan commented 3 weeks ago

Added @Adrien-D