argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

refactor(ui): simplify retry node by parametrizing retry workflow panel #13814

Open agilgur5 opened 4 weeks ago

agilgur5 commented 4 weeks ago

Fixes https://github.com/argoproj/argo-workflows/pull/13343#pullrequestreview-2359030878

Motivation

Simplifies and consolidates UI manual retry code -- 100+ LoC consolidated

Modifications

Verification

Manually tested, works same as before, but with nicer styling + animation. See screenshots above

agilgur5 commented 4 weeks ago

I couldn't request a review from @Adrien-D due to not being in the "members" team -- same reason as https://github.com/argoproj/argo-workflows/issues/8790#issuecomment-2412016304 -- so tagging in this comment instead

EDIT: now possible after https://github.com/argoproj/argo-workflows/pull/13813#issuecomment-2439219214