Open agilgur5 opened 4 weeks ago
I couldn't request a review from @Adrien-D due to not being in the "members" team -- same reason as https://github.com/argoproj/argo-workflows/issues/8790#issuecomment-2412016304 -- so tagging in this comment instead
EDIT: now possible after https://github.com/argoproj/argo-workflows/pull/13813#issuecomment-2439219214
Fixes https://github.com/argoproj/argo-workflows/pull/13343#pullrequestreview-2359030878
Motivation
Simplifies and consolidates UI manual retry code -- 100+ LoC consolidated
Modifications
parametrize based on the optional
props.nodeId
props.onRetrySuccess
can actually be used in both variantsuse the same retry panel element for both as (not just component)
Screenshots:
before: ![Screenshot 2024-10-24 at 9 02 25 PM](https://github.com/user-attachments/assets/3d322940-f65e-4c50-b845-7448c1b997f8) after: ![Screenshot 2024-10-24 at 9 23 17 PM](https://github.com/user-attachments/assets/eaa792a8-8e76-42d5-81cc-6e11e9d38685)fix types to not be optional in
workflow-node-info.tsx
(fixes https://github.com/argoproj/argo-workflows/pull/13343#discussion_r1794714750) and simplify code as suchplus a few small other simplifications as mentioned in my above linked review
Verification
Manually tested, works same as before, but with nicer styling + animation. See screenshots above