Closed agilgur5 closed 3 weeks ago
Fixes #12539 "Future Work" part 2
Remove unnecessary nesting, same as #12539
move ui/src/models to ui/src/shared/models
ui/src/models
ui/src/shared/models
then flatten ui/src/app to just ui/src/
ui/src/app
ui/src/
also fix name of workflow-operation-map.tsx to .ts as it doesn't have JSX/TSX (fixes https://github.com/argoproj/argo-workflows/pull/11121#discussion_r1561987261)
workflow-operation-map.tsx
.ts
also move webpack.config.js out of ui/src/app and to ui/
webpack.config.js
ui/
tsconfig.json
make start UI=true
yarn lint
yarn build
make server/static/files.go STATIC_FILES=true
ls dist/app
Use the sidebar in GH to see the files that weren't just renamed, which is only a small handful and mostly the last few config files
This will merge conflict with some of my other open PRs that delete or change imports; can update depending on what is merged first
Yes I mentioned that under "Modifications"
Fixes #12539 "Future Work" part 2
Motivation
Remove unnecessary nesting, same as #12539
Modifications
move
ui/src/models
toui/src/shared/models
then flatten
ui/src/app
to justui/src/
also fix name of
workflow-operation-map.tsx
to.ts
as it doesn't have JSX/TSX (fixes https://github.com/argoproj/argo-workflows/pull/11121#discussion_r1561987261)also move
webpack.config.js
out ofui/src/app
and toui/
tsconfig.json
Verification
make start UI=true
loads the UI fine and dandy and it works as beforeyarn lint
andyarn build
etc all passmake server/static/files.go STATIC_FILES=true
works/passesls dist/app
looks about the same before/after:Notes to Reviewers
Use the sidebar in GH to see the files that weren't just renamed, which is only a small handful and mostly the last few config files
This will merge conflict with some of my other open PRs that delete or change imports; can update depending on what is merged first