argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

refactor(ui): flatten `ui/src/app` dir #13815

Closed agilgur5 closed 3 weeks ago

agilgur5 commented 4 weeks ago

Fixes #12539 "Future Work" part 2

Motivation

Remove unnecessary nesting, same as #12539

Modifications

Verification

  1. make start UI=true loads the UI fine and dandy and it works as before
  2. yarn lint and yarn build etc all pass
  3. make server/static/files.go STATIC_FILES=true works/passes
  4. ls dist/app looks about the same before/after:
before: ``` ❯ ls dist/app 775.43e8c969ca85676f528d.js argo-ui-logs-viewer.ae9615e8f7f5b591df8e.js.map monaco-editor.fa9e75b9e342fbb964bb.js.LICENSE.txt 775.43e8c969ca85676f528d.js.LICENSE.txt assets monaco-editor.fa9e75b9e342fbb964bb.js.map 775.43e8c969ca85676f528d.js.map codicon.ttf react-markdown-plus-gfm.3a77fefac0c77fa0b385.js 839.58e22fba88631d094daf.js editor.worker.js react-markdown-plus-gfm.3a77fefac0c77fa0b385.js.map 839.58e22fba88631d094daf.js.LICENSE.txt editor.worker.js.map react-monaco-editor.9c2ee7a658ee5378c65b.js 839.58e22fba88631d094daf.js.map index.html react-monaco-editor.9c2ee7a658ee5378c65b.js.map 990.e6d98ce60f5195aec70a.js json.worker.js reports.17861f7c283f72c6ea9b.js 990.e6d98ce60f5195aec70a.js.LICENSE.txt json.worker.js.LICENSE.txt reports.17861f7c283f72c6ea9b.js.map 990.e6d98ce60f5195aec70a.js.map json.worker.js.map swagger-ui-react-css.dfee358b653e751976b0.js 994.eae31bc7956069a7bb1d.js main.e0032a966b1e70172630.js swagger-ui-react-css.dfee358b653e751976b0.js.map 994.eae31bc7956069a7bb1d.js.LICENSE.txt main.e0032a966b1e70172630.js.LICENSE.txt swagger-ui-react.e89a642a6a2e1d7b1970.js 994.eae31bc7956069a7bb1d.js.map main.e0032a966b1e70172630.js.map swagger-ui-react.e89a642a6a2e1d7b1970.js.LICENSE.txt argo-ui-logs-viewer.ae9615e8f7f5b591df8e.js monaco-editor.fa9e75b9e342fbb964bb.js swagger-ui-react.e89a642a6a2e1d7b1970.js.map ``` after: ``` ❯ ls dist/app/ 775.43e8c969ca85676f528d.js argo-ui-logs-viewer.ae9615e8f7f5b591df8e.js.map monaco-editor.92ae73621991273cd7fa.js.LICENSE.txt 775.43e8c969ca85676f528d.js.LICENSE.txt assets/ monaco-editor.92ae73621991273cd7fa.js.map 775.43e8c969ca85676f528d.js.map codicon.ttf react-markdown-plus-gfm.d507f040b86c97f5d729.js 839.58e22fba88631d094daf.js editor.worker.js react-markdown-plus-gfm.d507f040b86c97f5d729.js.map 839.58e22fba88631d094daf.js.LICENSE.txt editor.worker.js.map react-monaco-editor.9c2ee7a658ee5378c65b.js 839.58e22fba88631d094daf.js.map index.html react-monaco-editor.9c2ee7a658ee5378c65b.js.map 990.e6d98ce60f5195aec70a.js json.worker.js reports.aeeaa52ae94633cc90fc.js 990.e6d98ce60f5195aec70a.js.LICENSE.txt json.worker.js.LICENSE.txt reports.aeeaa52ae94633cc90fc.js.map 990.e6d98ce60f5195aec70a.js.map json.worker.js.map swagger-ui-react-css.dfee358b653e751976b0.js 994.eae31bc7956069a7bb1d.js main.4c6024a7ded227c8d4f0.js swagger-ui-react-css.dfee358b653e751976b0.js.map 994.eae31bc7956069a7bb1d.js.LICENSE.txt main.4c6024a7ded227c8d4f0.js.LICENSE.txt swagger-ui-react.e89a642a6a2e1d7b1970.js 994.eae31bc7956069a7bb1d.js.map main.4c6024a7ded227c8d4f0.js.map swagger-ui-react.e89a642a6a2e1d7b1970.js.LICENSE.txt argo-ui-logs-viewer.ae9615e8f7f5b591df8e.js monaco-editor.92ae73621991273cd7fa.js swagger-ui-react.e89a642a6a2e1d7b1970.js.map ```

Notes to Reviewers

agilgur5 commented 3 weeks ago

Yes I mentioned that under "Modifications"