argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

fix(deps): revert React 18 upgrade back to React 16 #13821

Open agilgur5 opened 3 weeks ago

agilgur5 commented 3 weeks ago

Fixes #13410 per https://github.com/argoproj/argo-workflows/pull/13069#pullrequestreview-2079815858, effectively reverting the React upgrade part of #13069

Motivation

Modifications

Verification

  1. Significantly less warnings during yarn install, only the expected ones from transitive deps or incorrect peerDeps of deps per https://github.com/argoproj/argo-workflows/issues/13410#issuecomment-2257365014
  2. Manually tested UI with make start UI=true, functions fine with a few actions.
    1. Significantly less warnings in the browser console, only one expected one from transitive deps
  3. yarn build and yarn lint pass.
agilgur5 commented 2 weeks ago

Draft until #13818 is merged, as this builds on top of it

This has been rebased on top now