the main purpose of the upgrade was to be able to upgrade swagger-ui-react, which had an alternate React 16 compatible path and has now been removed from the UI codebase entirely as of #13818
so the upgrade is no longer necessary for that purpose
Modifications
downgrade back to React 16 and revert render changes to use React 16 syntax
Fixes #13410 per https://github.com/argoproj/argo-workflows/pull/13069#pullrequestreview-2079815858, effectively reverting the React upgrade part of #13069
Motivation
not all of our deps are compatible with React 18 and so this caused many warnings (during install and in the browser console) as well as some bugs (https://github.com/argoproj/argo-workflows/pull/13593)
argo-ui
or decoupling the dependency onargo-ui
react-router
inargo-ui
, although that's not the only dep relying on old React inargo-ui
(react-form
,react-autocomplete
, and some of the components are too IIRC)the main purpose of the upgrade was to be able to upgrade
swagger-ui-react
, which had an alternate React 16 compatible path and has now been removed from the UI codebase entirely as of #13818Modifications
render
changes to use React 16 syntaxVerification
yarn install
, only the expected ones from transitive deps or incorrect peerDeps of deps per https://github.com/argoproj/argo-workflows/issues/13410#issuecomment-2257365014make start UI=true
, functions fine with a few actions.yarn build
andyarn lint
pass.