refactor(ui): replace deprecated usage of `defaultProps` - Githubissues

argoproj / argo-workflows

Workflow Engine for Kubernetes

https://argo-workflows.readthedocs.io/

Apache License 2.0

15.11k stars 3.21k forks source link

refactor(ui): replace deprecated usage of `defaultProps` #13822

Closed agilgur5 closed 3 weeks ago

agilgur5 commented 4 weeks ago

Fixes some React 18 warnings noted in https://github.com/argoproj/argo-workflows/pull/13069#issuecomment-2159579279:

react-dom.development.js:58 Warning: GraphPanel: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

Motivation

Future proofs some code that used deprecated defaultProps (and has warnings in React 18) by using JS default parameters instead

Modifications

GraphPanel.defaultProps.nodeSize -> defaultNodeSize const
- can't quite seamlessly use a default parameter here as it was also used as a constant in a few places
KeyValueEditor.defaultProps.keyValues: {} -> keyValues = {} default parameter

Verification