search

argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

ci: login to Docker Hub to avoid rate limiting #13830

Closed MasonM closed 2 weeks ago

MasonM commented 3 weeks ago

Partial fix for #10807

Motivation

E2E test builds are occasionally failing while pulling images from Docker Hub due to rate limiting. Example:

Oct 28 23:30:52 fv-az802-461 k3s[2185]: E1028 23:30:52.151698 2185 kuberuntime_image.go:53] "Failed to pull image" err="Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit" image="minio/minio:RELEASE.2022-11-17T23-20-09Z"

As explained in the error, logging in increases the limit.

Modifications

We're already doing this in the "Release" workflow, so this copies that over: https://github.com/argoproj/argo-workflows/blob/eb23eb6b84a1ecf0826a4e16d6a2032fd0cb08b7/.github/workflows/release.yaml#L51-L55

Verification

Wait for actions to run

MasonM commented 3 weeks ago

Seems it's not working, probably because of "With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository" - https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

Not sure if there's anything we can do about this

MasonM commented 2 weeks ago

https://github.com/argoproj/argo-workflows/issues/10807#issuecomment-2452045846