Open coreyhinkle opened 2 weeks ago
It seems to be related to the workflowtaskresult not being completed. After encountering "WorkflowSpec may not change during execution when the controller is set `templateReferencing: Secure", I saw that the workflow-controller executed
err := woc.setStoredWfSpec()
if err != nil {
woc.markWorkflowError(ctx, err)
return err
}
Pre-requisites
:latest
image tag (i.e.quay.io/argoproj/workflow-controller:latest
) and can confirm the issue still exists on:latest
. If not, I have explained why, in detail, in my description below.What happened? What did you expect to happen?
When a workflow template is changed while a workflow is running in
templateReferencing: Secure
mode I expect workflows to fail. What I've seen is if a workflow is in the last step when it is edited, the workflow gets stuck in a constant running state after the script completes.I was able to reproduce this by using the below workflow, waiting for it to hit the sleep, and then adding
echo "test"
after the sleep.Version(s)
v3.5.10, v.3.5.12, c702ab72433eb8cd26db07f0025dceba91e5e994c8071b0df89b27b63a73f0d2
Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container