search

argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.21k forks source link

chore(tests): fix lint failures #13853

Closed MasonM closed 2 weeks ago

MasonM commented 2 weeks ago

Motivation

Every PR has been failing the make lint checked with the following error since https://github.com/argoproj/argo-workflows/pull/12960 was merged (example):

            assert.Equal(t, 1, len(status.Outputs.Parameters))
            ^
Error: test/e2e/suspend_test.go:124:4: len: use assert.Len (testifylint)
            assert.Equal(t, 1, len(status.Inputs.Parameters))
            ^
make: *** [Makefile:466: lint] Error 1

This is happening due to a conflict between that PR and https://github.com/argoproj/argo-workflows/pull/13467. The latter PR was merged on August 14th, but the latest CI run for the former was on May 22nd.

Modifications

Change to use assert.Len()

Verification

Ran make lint locally

Joibel commented 2 weeks ago

Thank you for doing this