argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.11k stars 3.2k forks source link

feat: mark memoized node as cached #13882

Closed MenD32 closed 1 week ago

MenD32 commented 1 week ago

Fixes https://github.com/argoproj/argo-workflows/issues/13848

Motivation

when using memoization, its much easier to debug workflows when you can see that nodes have been cached. currently in large workflows you'd have to go over all the nodes one by one to understand if they are cached, or you could go to the timeline tab. both of those options offer a bad user experience, that becomes worse as the workflows get larger.

Modifications

changed the icon of successful cached nodes to a database icon (from font awesome) to mark them as cached.

Verification

tested in the UI that it works using the examples/memoized-simple.yaml example

screenshots:

first workflow (no cache hit)

Screenshot 2024-11-08 at 14 53 33

second workflow (cache hit)

Screenshot 2024-11-08 at 14 53 50