UI (when 2 tabs open) 3.6.0rc4 - submit workflowtemplate greyed out

tooptoop4 commented 1 week ago

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

in the ui it lets me create a new workflowtemplate and update it, but the button to submit it is greyed out. i'm using the quickstart

Version(s)

3.6.0rc4

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

default

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

n/a

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

n/a

tooptoop4 commented 1 week ago

for this to happen looks like you need 2 workflow tabs open (in any of chrome or safari), workaround is to hard refresh via hold down command+shift keys and click the refresh icon in address bar

@MasonM maybe caused by https://github.com/argoproj/argo-workflows/commit/68adbcc0cce29e4daa37b521f02ca2fccec1ca2c#diff-0494089cd084aa91c5d8e043b283fe327f53ecf94623bf82be945dea2e2587fd ?

Joibel commented 1 week ago

I can reproduce this on firefox 131 on linux. I don't need a hard refresh, just a normal refresh to make the button appear, and the button appears greyed out without 2 tabs.

MasonM commented 1 week ago

@tooptoop4 The "submit" button was completely broken before that change for the reasons described at https://github.com/argoproj/argo-workflows/pull/13593, so it definitely didn't cause this. If this was a regression, it dates back at least to https://github.com/argoproj/argo-workflows/pull/13069

MasonM commented 1 week ago

Looking at this more, I think this is a consequence of reference equality checking. In my original fix for https://github.com/argoproj/argo-workflows/pull/13593, I had it use deep equality comparisons, which doesn't have this problem. However, I reverted that in https://github.com/argoproj/argo-workflows/pull/13593/commits/24c0206b9071503467034cb67716ef0b27158b0f because Anton had concerns about performance (see https://github.com/argoproj/argo-workflows/pull/13593#discussion_r1769673834). I did figure out a way to fix this without affecting performance (see https://github.com/argoproj/argo-workflows/pull/13593#discussion_r1781972661), but the problem is that's a significant change, and I don't know if there's anyone left that can code review such a change. So I think we're just going to have to live with this until there's someone available to code review UI changes.

isubasinghe commented 1 week ago

@MasonM I did initially start on argo with some UI contributions, I am a bit rusty, but I can review your code.

MasonM commented 3 days ago

@isubasinghe Thanks! I cleaned up the POC and entered https://github.com/argoproj/argo-workflows/pull/13915 for this

MasonM commented 2 days ago

Re-opening because https://github.com/argoproj/argo-workflows/pull/13913 didn't fully fix the issue, e.g. the "Submit" button is still grayed out after clicking "Update" button. https://github.com/argoproj/argo-workflows/pull/13915 will completely fix it.

argoproj / argo-workflows