argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
14.85k stars 3.17k forks source link

v3.1.3 Cherry-pick #6435

Closed sarabala1979 closed 3 years ago

sarabala1979 commented 3 years ago
alexec commented 3 years ago

@terrytangyuan do you want to mark any for OSS? @tczhao there are a few fixes for GCS is this list. Do you think they should be included?

alexec commented 3 years ago

I'd like to include #6434, once it is merged. @sarabala1979 otherwise I have marked the fixes I want to include

sarabala1979 commented 3 years ago
terrytangyuan commented 3 years ago

Nothing to include for OSS for this release but could you include the following commit?

Yuan Tang: feat(controller): Allow configurable host name label key when retrying different hosts #6341 d6ec032

tczhao commented 3 years ago

I'm keen to include the GCS fixes

alexec commented 3 years ago

Released!

Bobgy commented 3 years ago

Hi @alexec @sarabala1979, I think we missed cherry picking my first PR fix for emissary with nonroot: https://github.com/argoproj/argo-workflows/pull/6247/files. It's also required for running emissary with nonroot containers.

https://github.com/argoproj/argo-workflows/blob/release-3.1/workflow/executor/emissary/binary.go#L19

sarabala1979 commented 3 years ago

@terrytangyuan We already released v3.1.3. Which includes only the checked once. Sorry, we missed your comments. you might be commented after we start releasing process. I can do 3.1.4 this week. I will create cherry-pick issue tomorrow.

Bobgy commented 3 years ago

No worries, thank you for the quick response! Looking forward to the next release.