argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.02k stars 3.2k forks source link

v3.1.4 cherry-pick #6468

Closed sarabala1979 closed 3 years ago

sarabala1979 commented 3 years ago

Few PRs are already released in v3.1.3. Please select your PR that needs to release in v3.1.4

alexec commented 3 years ago

@Bobgy can you mark the ones you needed again please?

Bobgy commented 3 years ago

Thanks! I was talking about https://github.com/argoproj/argo-workflows/pull/6247. It's not in the list.

nit: What permission do I need to check boxes here?

Bobgy commented 3 years ago

I want this too

Yuan (Bob) Gong: fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts (fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts #6403) 30e2518

But I think it's already cherry picked

sarabala1979 commented 3 years ago

@Bobgy I selected it. Do you have any more issues that need to be included in v3.1.4? I am planning to start release tomorrow

Bobgy commented 3 years ago

Thanks, I didn't hit any other issues so far.

I am just curious, I think some fixes like the following are generally good to have, but they are not picked at the moment. How do you decide?

Antoine Dao: fix(emissary): throw argo error on file not exist (fix(emissary): throw argo error on file not exist #6392) b17d1bf

Alex Collins: fix(executor): Remove 15s guard for Docker executor. Fixes wait container won't exit #6415 (fix(executor): Remove 15s guard for Docker executor. Fixes #6415 #6427)

sarabala1979 commented 3 years ago

@Bobgy We will go with the below order

  1. Regression issues must be included
  2. Other fixes based on usecase/no of user facing/ user request/ risk factor.
sarabala1979 commented 3 years ago
Bobgy commented 3 years ago

Hi @sarabala1979, I'm still not seeing my fix in #6247 cherrypicked into 3.1.4. https://github.com/argoproj/argo-workflows/blob/v3.1.4/workflow/executor/emissary/binary.go#L19

sarabala1979 commented 3 years ago

I did cherry pick and resolve conflict on windows file. Let me check.

Sent from my iPhone

On Aug 3, 2021, at 7:08 PM, Yuan (Bob) Gong @.***> wrote:

 Hi @sarabala1979, I'm still not seeing my fix in #6247 cherrypicked into 3.1.4. https://github.com/argoproj/argo-workflows/blob/247776d66fa6bf988f861ba82f181e386a972626/workflow/executor/emissary/binary.go#L19

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

sarabala1979 commented 3 years ago

@Bobgy I miss understood. I was including Yuan (Bob) Gong: fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts (fix(executor/emissary): fix nonroot sidecars + input/output params & artifacts #6403) 30e2518. I missed your comment saying the issue is not on the list. finally, find it https://github.com/argoproj/argo-workflows/commit/05c901fd4f622aa9aa87b3eabfc87f0bec6dea30 somewhat it was missed in 3.1.3 also. I am releasing v3.1.5

Bobgy commented 3 years ago

Yes, it's a different PR. Sorry I split my fix into multiple PRs in the first place. I see it makes it more confusing than necessary. I'll test more cases in the initial PR next time. : )