argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
14.98k stars 3.19k forks source link

v3.2.9 Cherry-pick #8043

Closed sarabala1979 closed 2 years ago

sarabala1979 commented 2 years ago

Planning to release v3.2.9 end of today. Please select your issues which you want to include in this release

alexec commented 2 years ago

@sarabala1979 can I request

sarabala1979 commented 2 years ago

done. issues have fix subject that's why it is included. I will do a manual check next time. I got PRs from last hash in v3.2 to master HEAD.

alexec commented 2 years ago

Can I leave it with you to review the list and include any bug fixes you think we need?

sarabala1979 commented 2 years ago

sure

alexec commented 2 years ago

CI build is broken:

test-functional:

Error: test/e2e/semaphore_test.go:79:18: too many arguments in call to s.E2ESuite.Given().Workflow("@functional/synchronization-tmpl-level-mutex-semaphore.yaml").When().CreateConfigMap
[15](https://github.com/argoproj/argo-workflows/runs/5385554814?check_suite_focus=true#step:17:15)
    have (string, map[string]string, map[string]string)
[16](https://github.com/argoproj/argo-workflows/runs/5385554814?check_suite_focus=true#step:17:16)
    want (string, map[string]string)
[17](https://github.com/argoproj/argo-workflows/runs/5385554814?check_suite_focus=true#step:17:17)
FAIL    github.com/argoproj/argo-workflows/v3/test/e2e [build failed]

test-examples:

VERIFICATION
[11052](https://github.com/argoproj/argo-workflows/runs/5385554895?check_suite_focus=true#step:17:11052)
make: *** [Makefile:497: test-examples] Error 1
[11053](https://github.com/argoproj/argo-workflows/runs/5385554895?check_suite_focus=true#step:17:11053)
✖ http-template-bfkpq: AssertionError

lint

Running [/home/runner/golangci-lint-1.42.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
[74](https://github.com/argoproj/argo-workflows/runs/5385655918?check_suite_focus=true#step:4:74)
  Error: too many arguments (typecheck)
[73](https://github.com/argoproj/argo-workflows/runs/5385655918?check_suite_focus=true#step:4:73)
  Running [/home/runner/golangci-lint-1.42.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
[74](https://github.com/argoproj/argo-workflows/runs/5385655918?check_suite_focus=true#step:4:74)
  Error: too many arguments (typecheck)