argoproj / argo-workflows

Workflow Engine for Kubernetes
https://argo-workflows.readthedocs.io/
Apache License 2.0
15.13k stars 3.21k forks source link

UI returns 500 on WorkflowTemplates tap if one WorkflowTemplate is invalid #9316

Closed nice-pink closed 2 years ago

nice-pink commented 2 years ago

Checklist

* [x] Double-checked my configuration. * [x] Tested using the latest version. * [x] Used the Emissary executor. ## Summary What happened/what you expected to happen? I pushed a broken version of a WorkflowTempate to the cluster. Clicking on the WorkflowTemplates tap in the argo-workflows UI returns 500 and I can't see any WorkflowTemplates. The error message is: "Unsuccessful HTTP response: json: cannot unmarshal object into Go struct field DAGTask.items.spec.templates.dag.tasks.template of type string" I understand the behavior, it would still be nice to get a list of valid WorkflowTemplates. What version are you running? v3.3.8 ## Diagnostics Paste the smallest workflow that reproduces the bug. We must be able to run the workflow. ```yaml apiVersion: argoproj.io/v1alpha1 kind: WorkflowTemplate metadata: name: check-cond spec: serviceAccountName: workflow templates: dag: tasks: - name: print template: name: go-print container: image: docker/whalesay:latest command: [cowsay] args: ["printed"] ``` ---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

juliev0 commented 2 years ago

I was able to reproduce this and seems like a real bug. (Therefore, removing the "Triage" label.) I did also confirm that it works again if you delete the WorkflowTemplate.

tooptoop4 commented 2 years ago

any fix? delete does not work either

juliev0 commented 2 years ago

Unfortunately, there are higher priority items right now. Maybe somebody from the community can pick it up?

alexec commented 2 years ago

Work-around: delete the bad workflow template.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

tooptoop4 commented 1 month ago

similar to https://github.com/argoproj/argo-workflows/issues/10229 and https://github.com/argoproj/argo-workflows/issues/10264