Open jsoref opened 2 years ago
Retry will run the existing failed workflow whereas resubmit will submit a new workflow with the same spec.
Just to a little bit of clarity. Retry reruns the failed step/task(s) from the existing failed workflow
It sounds like retry will only rerun the failed bits (and cascading following bits) whereas resubmit will start from scratch.
A user shouldn't have to file a bug to find out that distinction, it should be clear from the documentation and it should be clear from the UI.
The docs for each item should clearly indicate what the specific thing does and mention the other one and hint at when one would want to use the other instead,
Note: I don't generally advocate GitHub UI elements (I file way more bugs about GitHub than I do about Argo*), but it's worth considering this similar GitHub element:
It's easy to understand that there are two similar actions, and it's easy to understand that one is clearly a subset of the other and roughly how it's a subset.
Clicking that first option yields:
The extra sentence clarifies what extra (non-failing) items could be run.
Was looking to add this myself and then found this issue again. Gonna work on this in tandem with docs and help text changes for https://github.com/argoproj/argo-workflows/issues/11511
Would also like to add tooltips for Terminate vs. Stop as well. Terminate vs. Stop and Retry vs. Resubmit are perhaps the most frequently asked questions I've seen (and personally asked/searched for too).
For anyone finding themselves here: retry vs. resubmit terminate vs. stop
One small complication here, these buttons are rendered via the ActionMenu
component (tracing: getItems
has the items
, which use the WorkflowOperationsMap
), which is actually in argo-ui
and does not have a prop for tooltips. So will need to add tooltips in argo-ui
, then update and add the tooltip contents here.
Also for the CLI and its docs, I wrote up #11625 to describe retry
vs. resubmit
in more details
Summary
Documentation and UX need to make it clear how
retry
andresubmit
differ.https://argoproj.github.io/argo-workflows/cli/argo_retry/
https://argoproj.github.io/argo-workflows/cli/argo_resubmit/
Use Cases
Someone trying to understand when to use
retry
and when to useresubmit
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.