search

argoproj / argoproj-deployments

Deployment repository for Argoproj CI/CD
https://cd.apps.argoproj.io
235 stars 124 forks source link

Update argocd-server-deploy-command.yaml #16

Closed lanthosbrs closed 1 year ago

lanthosbrs commented 1 year ago

Updated the deployment command to target arg instead of command

Signed-off-by: Brian Slocum brian@liquidfuture.net

agilgur5 commented 7 months ago

Looks like this was replaced by #17, #18, and then #19

lanthosbrs commented 7 months ago

Yep it was. I was still learning how to get everything correct

agilgur5 commented 7 months ago

Gotcha. It's best practice to use the same PR when possible (can force push over anything if you need to usually). If you do need to make a new PR, a reference to that like I made above is very helpful for posterity. So that when someone stumbled upon it (like me just now), they know what happened to it (a lot easier than trying to dig through history when someone points you directly)