search

argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

fix: ensureCRDReady check did not work for v1 CRDs #378

Closed terrytangyuan closed 2 years ago

terrytangyuan commented 2 years ago

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #378 (2346a73) into master (e360551) will decrease coverage by 0.02%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   49.35%   49.32%   -0.03%     
==========================================
  Files          41       41              
  Lines        3353     3355       +2     
==========================================
  Hits         1655     1655              
- Misses       1535     1537       +2     
  Partials      163      163
Impacted Files Coverage Δ
pkg/sync/sync_context.go 71.28% <0.00%> (-0.24%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e360551...2346a73. Read the comment docs.

jessesuen commented 2 years ago

Context for others: kubernetes apiextensions v1beta1 is no longer served in v1.22 and the e2e upgrade to test v1.22 (https://github.com/argoproj/argo-cd/pull/8431) exposed the fact that we didn't wait for CRDs to be registered properly before moving to CR instances.