Closed terrytangyuan closed 2 years ago
Merging #381 (119f9b9) into master (61c0cc7) will increase coverage by
4.91%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 49.34% 54.25% +4.91%
==========================================
Files 41 41
Lines 3356 3052 -304
==========================================
Hits 1656 1656
+ Misses 1537 1233 -304
Partials 163 163
Impacted Files | Coverage Δ | |
---|---|---|
pkg/health/health.go | 60.56% <ø> (+4.71%) |
:arrow_up: |
pkg/health/health_daemonset.go | 35.29% <ø> (+22.52%) |
:arrow_up: |
pkg/health/health_deployment.go | 57.14% <ø> (+36.99%) |
:arrow_up: |
pkg/health/health_replicaset.go | 0.00% <ø> (ø) |
|
pkg/health/health_statefulset.go | 23.91% <ø> (+15.70%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 61c0cc7...119f9b9. Read the comment docs.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Marking as draft to wait until Argo CD 2.3 is released to avoid any risks
Now that 2.3.0 has been released. This is ready for review. @jessesuen @alexmt
This PR removed all extensions APIs besides Ingress because extensions Ingress is still available in 1.21. We will remove it later when 1.21 has reached to EOL.
Reference: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
Signed-off-by: Yuan Tang terrytangyuan@gmail.com