argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

chore: Remove support for deprecated extensions APIs #381

Closed terrytangyuan closed 2 years ago

terrytangyuan commented 2 years ago

This PR removed all extensions APIs besides Ingress because extensions Ingress is still available in 1.21. We will remove it later when 1.21 has reached to EOL.

Reference: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #381 (119f9b9) into master (61c0cc7) will increase coverage by 4.91%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   49.34%   54.25%   +4.91%     
==========================================
  Files          41       41              
  Lines        3356     3052     -304     
==========================================
  Hits         1656     1656              
+ Misses       1537     1233     -304     
  Partials      163      163              
Impacted Files Coverage Δ
pkg/health/health.go 60.56% <ø> (+4.71%) :arrow_up:
pkg/health/health_daemonset.go 35.29% <ø> (+22.52%) :arrow_up:
pkg/health/health_deployment.go 57.14% <ø> (+36.99%) :arrow_up:
pkg/health/health_replicaset.go 0.00% <ø> (ø)
pkg/health/health_statefulset.go 23.91% <ø> (+15.70%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61c0cc7...119f9b9. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

terrytangyuan commented 2 years ago

Marking as draft to wait until Argo CD 2.3 is released to avoid any risks

terrytangyuan commented 2 years ago

Now that 2.3.0 has been released. This is ready for review. @jessesuen @alexmt