argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.68k stars 252 forks source link

feat: Support health check on Argo CronWorkflows #382

Closed terrytangyuan closed 2 years ago

terrytangyuan commented 2 years ago

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #382 (7c03c89) into master (61c0cc7) will increase coverage by 0.44%. The diff coverage is 87.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   49.34%   49.79%   +0.44%     
==========================================
  Files          41       41              
  Lines        3356     3394      +38     
==========================================
+ Hits         1656     1690      +34     
- Misses       1537     1540       +3     
- Partials      163      164       +1     
Impacted Files Coverage Δ
pkg/health/health.go 54.43% <0.00%> (-1.42%) :arrow_down:
pkg/health/health_argo.go 85.41% <92.30%> (+27.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61c0cc7...7c03c89. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
28.6% 28.6% Duplication

terrytangyuan commented 2 years ago

Closing this in favor of https://github.com/argoproj/argo-cd/pull/8570