argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

feat: support exiting early from IterateHierarchy method #388

Closed alexmt closed 2 years ago

alexmt commented 2 years ago

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #388 (3f3421c) into master (531c0db) will increase coverage by 0.01%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   54.25%   54.27%   +0.01%     
==========================================
  Files          41       41              
  Lines        3052     3053       +1     
==========================================
+ Hits         1656     1657       +1     
  Misses       1233     1233              
  Partials      163      163              
Impacted Files Coverage Δ
pkg/cache/cluster.go 53.54% <57.14%> (+0.09%) :arrow_up:
pkg/cache/resource.go 70.00% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 531c0db...3f3421c. Read the comment docs.

alexmt commented 2 years ago

Thank you for review @jessesuen , PTAL

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.1% 3.1% Duplication