Codecov Report

Merging #404 (8d7183d) into master (b855894) will decrease coverage by 0.54%. The diff coverage is 2.70%.

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   54.52%   53.98%   -0.55%     
==========================================
  Files          41       41              
  Lines        3059     3090      +31     
==========================================
  Hits         1668     1668              
- Misses       1228     1258      +30     
- Partials      163      164       +1

Impacted Files	Coverage Δ
pkg/utils/kube/ctl.go	`4.93% <0.00%> (-0.70%)`	:arrow_down:
pkg/cache/cluster.go	`54.36% <6.66%> (-1.22%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b855894...8d7183d. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.2% Duplication

rishabh625 commented 2 years ago

Hey @leoluz : m still trying to understand the code, but i have a question, Was this change imported in argo-cd and tested ? (ValidatingWebhookConfiguration case): Bug causing wrong diff calculation inside nested lists in CRDs with managed fields ignore configs.

is there any fork we could know that this fixes above

rishabh625 commented 2 years ago

Hey @leoluz : m still trying to understand the code, but i have a question, Was this change imported in argo-cd and tested ? (ValidatingWebhookConfiguration case): Bug causing wrong diff calculation inside nested lists in CRDs with managed fields ignore configs.

is there any fork we could know that this fixes above

looks like this has https://github.com/argoproj/argo-cd/pull/9170/files

argoproj / gitops-engine

feat: add GvkParser in cluster cache #404

Codecov Report