EppO commented 2 years ago

Currently health check for HorizontalPodAutoscaler is limited to v1, v2beta1 and v2beta2. This MR adds support for v2 which is the default HPA API version on Kubernetes 1.23+

Without this MR, ArgoCD will fail to sync any applications that use HPA in Kubernetes 1.23+ clusters.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #411 (eef0669) into master (b855894) will increase coverage by 0.14%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   54.52%   54.66%   +0.14%     
==========================================
  Files          41       41              
  Lines        3059     3073      +14     
==========================================
+ Hits         1668     1680      +12     
- Misses       1228     1229       +1     
- Partials      163      164       +1

Impacted Files	Coverage Δ
pkg/health/health_hpa.go	`82.75% <85.71%> (+0.56%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b855894...eef0669. Read the comment docs.

Var091 commented 2 years ago

Hi, do we have any updates on this one? can be this merged already?

ghost commented 2 years ago

please some one approve this MR, this is important for us :)

flaviolemos78 commented 2 years ago

Hi @alexmt any plans to also include this on v2.3?

argoproj / gitops-engine

feat: Add support for HPA v2 (autoscaling/v2) #411

Codecov Report