Support gitops-engine.argoproj.io annotations

argoproj / gitops-engine

Democratizing GitOps

https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories

Apache License 2.0

1.7k stars 262 forks source link

Support gitops-engine.argoproj.io annotations #43

Open alexmt opened 4 years ago

alexmt commented 4 years ago

The synchronization process is controlled by the following annotations:

argocd.argoproj.io/sync-wave
argocd.argoproj.io/hook
argocd.argoproj.io/hook-delete-policy
argocd.argoproj.io/sync-wave

We should get rid of argocd part since the engine is not specific to Argo CD. There are two possibilities:

Make annotation "domain" customizable
Support gitops-engine.argoproj.io/<type> in addition to argocd.argoproj.io/<type> .

jaypipes commented 4 years ago

I see no reason not to support the original annotations, actually. Those annotations refer to the ArgoCD user experience and contract and as such should stay the same. Long-term, it would be great to add support for any FluxCD annotations in addition to the ArgoCD ones. Thoughts?