search

argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

fix: structured-merge diff apply default values in live resource #435

Closed leoluz closed 2 years ago

leoluz commented 2 years ago

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #435 (4f20e9a) into master (1c4ef33) will decrease coverage by 0.07%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   54.03%   53.96%   -0.08%     
==========================================
  Files          41       41              
  Lines        3194     3189       -5     
==========================================
- Hits         1726     1721       -5     
  Misses       1286     1286              
  Partials      182      182
Impacted Files Coverage Δ
pkg/diff/diff.go 60.23% <66.66%> (-0.46%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

leoluz commented 2 years ago

@crenshaw-dev improved the unit-test a bit and added a verification to avoid regressions in the current bug