argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.68k stars 252 forks source link

feat: add annotation to the custom namesapce #440

Closed ashutosh16 closed 2 years ago

ashutosh16 commented 2 years ago

Support annotation and labels for custom namespace. This is a prerequisite for fixing https://github.com/argoproj/argo-cd/issues/4628

This Argocd PR depends on this change Signed-off-by: Ashutosh mail.ashutosh8@gmail.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #440 (f62fe65) into master (e03364f) will increase coverage by 0.08%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   55.22%   55.31%   +0.08%     
==========================================
  Files          41       41              
  Lines        4449     4460      +11     
==========================================
+ Hits         2457     2467      +10     
- Misses       1803     1804       +1     
  Partials      189      189              
Impacted Files Coverage Δ
pkg/sync/common/types.go 54.16% <ø> (ø)
pkg/sync/sync_context.go 72.22% <83.33%> (+0.23%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ashutosh16 commented 2 years ago

Not require