search

argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

gitops-engine@v0.7.1 incompatible with argo-cd/v2 v2.4.10 #447

Open sk31337 opened 2 years ago

sk31337 commented 2 years ago

I am writing an go lang app which uses argo-cd/v2 v2.4.10.

Therefore I have included github.com/argoproj/argo-cd/v2 v2.4.10 in my go.mod file and added all replace() https://github.com/argoproj/argo-cd/blob/master/go.mod#L255

but I keep getting this error:

go vet ./...
# github.com/argoproj/gitops-engine/pkg/utils/kube
../../pkg/mod/github.com/argoproj/gitops-engine@v0.7.1/pkg/utils/kube/resource_ops.go:270:38: not enough arguments in call to k.fact.Validator
    have (bool)
    want (string, *"k8s.io/cli-runtime/pkg/resource".QueryParamVerifier)
../../pkg/mod/github.com/argoproj/gitops-engine@v0.7.1/pkg/utils/kube/resource_ops.go:278:30: undefined: resource.NewDryRunVerifier
../../pkg/mod/github.com/argoproj/gitops-engine@v0.7.1/pkg/utils/kube/resource_ops.go:326:30: undefined: resource.NewDryRunVerifier
../../pkg/mod/github.com/argoproj/gitops-engine@v0.7.1/pkg/utils/kube/resource_ops.go:375:30: undefined: resource.NewDryRunVerifier

Solution was to add another replace(): github.com/argoproj/gitops-engine => github.com/argoproj/gitops-engine v0.7.1-0.20220804190909-2bc3fef13e07

Request: May you release another v0.7.2 or include the changes of v0.7.1-0.20220804190909-2bc3fef13e07 into the existing v0.7.1?

I hope I didn't make any rookie mistake,

Cheers, Steffen

karlschriek commented 2 years ago

@sTb1337 do you have some more context on this? I am seeing the same thing with argo-cd 2.5.0 and gitops-engine v0.7.3. Where does v0.7.1-0.20220804190909-2bc3fef13e07 originate from? Is there a PR somehwere that deals with it?

RnkeZ commented 1 year ago

Hey, I'm using Argocd package v2.5.6 and I also had to replace the gitops-engine to v0.7.1-0.20220804190909-2bc3fef13e07. Any Idea when this will be resolved?

skandragon commented 10 months ago

Trying to use the latest versions of argo-cd/v2 and rollouts also causes a similar build issue if the k8s.io Kubernetes packages are upgraded beyond 0.25.15.

It looks like something is strange with how gitops-engine works, as that is always the problem, and even locking it down to the versions mentioned here does not help.