search

argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

fix: sort fields to correctly calculate diff in server-side apply #456

Closed leoluz closed 2 years ago

leoluz commented 2 years ago

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

Fix: https://github.com/argoproj/argo-cd/issues/10438

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #456 (f9c2313) into master (ce2fb70) will decrease coverage by 0.04%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   55.42%   55.38%   -0.05%     
==========================================
  Files          41       41              
  Lines        4469     4478       +9     
==========================================
+ Hits         2477     2480       +3     
- Misses       1803     1807       +4     
- Partials      189      191       +2
Impacted Files Coverage Δ
pkg/diff/diff.go 60.75% <33.33%> (-0.40%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.