argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

manage clusters via proxy #466

Closed ls0f closed 1 year ago

ls0f commented 2 years ago

Signed-off-by: ls0f lovedboy.tk@qq.com

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Base: 55.40% // Head: 55.37% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (414a076) compared to base (3951079). Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #466 +/- ## ========================================== - Coverage 55.40% 55.37% -0.03% ========================================== Files 41 41 Lines 4480 4486 +6 ========================================== + Hits 2482 2484 +2 - Misses 1807 1810 +3 - Partials 191 192 +1 ``` | [Impacted Files](https://codecov.io/gh/argoproj/gitops-engine/pull/466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj) | Coverage Δ | | |---|---|---| | [pkg/utils/kube/kube.go](https://codecov.io/gh/argoproj/gitops-engine/pull/466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL3V0aWxzL2t1YmUva3ViZS5nbw==) | `38.67% <33.33%> (-0.13%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jinnjwu commented 1 year ago

@ls0f any change to merge PR, thanks

jinnjwu commented 1 year ago

@crenshaw-dev any change to merge PR, thanks

jinnjwu commented 1 year ago

any chance to merge pr?

ls0f commented 1 year ago

@alexmt @crenshaw-dev Is there any progress?

manuelstein commented 1 year ago

@jannfis, @alexmt, been waiting on this fix for 5 months. k8s client go has allowed a ProxyURL for 4 years already. This PR simply passes the explicit cluster proxy k8s.io/client-go clientcmdapi ProxyURL. Is there anything we can do to get this merged?

murillovaz commented 1 year ago

Is there a reason this hasn't been merged yet? up

rochaporto commented 1 year ago

For others looking at this, it seems to be available in 2.8.x releases of argocd: https://github.com/argoproj/argo-cd/blob/v2.8.3/go.mod#L14C47-L14C52