search

argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

feat: ignore endpointslice modified events, and add tests #469

Closed fungiboletus closed 1 month ago

fungiboletus commented 2 years ago

This is related to a comment stating that endpointslice should be ignored.

codecov[bot] commented 2 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.95%. Comparing base (98ccd3d) to head (c89a5a1). Report is 47 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #469 +/- ## ========================================== + Coverage 55.46% 55.95% +0.48% ========================================== Files 41 41 Lines 4504 4504 ========================================== + Hits 2498 2520 +22 + Misses 1813 1794 -19 + Partials 193 190 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sidewinder12s commented 1 year ago

This would be useful, we have a lot of DaemonSets with services that are causing constant reconciliations due to constant cluster scaling.

aaemula commented 1 year ago

This change is awesome. So we don't have to manually configure the resource.exclusions.

aaemula commented 1 year ago

@crenshaw-dev @alexmt @jessesuen PTAL

diranged commented 9 months ago

What needs to be done to get this over the hump? This has a serious load impact for us (https://github.com/argoproj/argo-cd/issues/15594#issuecomment-1936709854).

fungiboletus commented 1 month ago

Is there a scenario where you don't want EndpointSlice to be ignored? I saw the code was ready to add more ignored ressources so I just added it there.

I think it's fine to have default ignored ressources in resource.exclusions instead. I wouldn't mind if someone else feels like implementing it :D

agaudreault commented 1 month ago

@fungiboletus we do have them in the UI because they contain useful networking information to identify and debug some network problems.

I created an issue for the 3.0 version to change the default settings https://github.com/argoproj/argo-cd/issues/20013 :)