search

argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 260 forks source link

meaningful ingress health message #471

Open bukowa opened 2 years ago

bukowa commented 2 years ago

Maybe someone knows a better message?

https://github.com/argoproj/argo-cd/issues/997

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Base: 55.46% // Head: 55.47% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (e5b6f91) compared to base (98ccd3d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #471 +/- ## ======================================= Coverage 55.46% 55.47% ======================================= Files 41 41 Lines 4504 4505 +1 ======================================= + Hits 2498 2499 +1 Misses 1813 1813 Partials 193 193 ``` | [Impacted Files](https://codecov.io/gh/argoproj/gitops-engine/pull/471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj) | Coverage Δ | | |---|---|---| | [pkg/health/health\_ingress.go](https://codecov.io/gh/argoproj/gitops-engine/pull/471/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL2hlYWx0aC9oZWFsdGhfaW5ncmVzcy5nbw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.