leoluz commented 1 year ago

When enabled, managed namespace shouldn't mutate the live state directly.

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.1% Duplication

codecov[bot] commented 1 year ago

Codecov Report

Base: 55.63% // Head: 55.63% // No change to project coverage :thumbsup:

Coverage data is based on head (3e05051) compared to base (b371e3b). Patch coverage: 69.23% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #479 +/- ## ======================================= Coverage 55.63% 55.63% ======================================= Files 41 41 Lines 4513 4513 ======================================= Hits 2511 2511 Misses 1808 1808 Partials 194 194 ``` | [Impacted Files](https://codecov.io/gh/argoproj/gitops-engine/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj) | Coverage Δ | | |---|---|---| | [pkg/sync/sync\_context.go](https://codecov.io/gh/argoproj/gitops-engine/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL3N5bmMvc3luY19jb250ZXh0Lmdv) | `73.34% <69.23%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

argoproj / gitops-engine

fix: managed namespaces should not mutate the live state #479

Codecov Report