search

argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.68k stars 252 forks source link

fix: add healthStatus on Application #487

Closed speedfl closed 1 year ago

speedfl commented 1 year ago

Closes #486

Purpose is to add Health status to Application.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ashutosh16 commented 1 year ago

Verified in my local and it's working as expected

Screen Shot 2022-12-15 at 1 03 01 AM
ashutosh16 commented 1 year ago

Do you need to update the Argocd application set documentation to reflect this change?

speedfl commented 1 year ago

Hey @ashutosh16 . Thanks a lot for your review. I don't think it is necessary to add documentation as the app applicationset is more a technical choice rather than a recommendation. A medium post (ongoing) will be sufficient :)

However I don't know the release process for this project. How to include it in Argocd

speedfl commented 1 year ago

Hi @alexmt I confirm using: https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/1.7-1.8/#health-assessment-of-argoprojioapplication-crd-has-been-removed it is now working. Thanks a lot 👍