argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 264 forks source link

feat: Expose validation webhook warnings in Argo CD UI #545

Open Mattes83 opened 1 year ago

Mattes83 commented 1 year ago

This is a follow up of #493

I tried to implement the proposals of @crenshaw-dev

What do you think?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 1 year ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a00ce82) 54.60% compared to head (40e9453) 54.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #545 +/- ## ========================================== - Coverage 54.60% 54.40% -0.20% ========================================== Files 41 41 Lines 4641 4661 +20 ========================================== + Hits 2534 2536 +2 - Misses 1911 1927 +16 - Partials 196 198 +2 ``` | [Files](https://app.codecov.io/gh/argoproj/gitops-engine/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj) | Coverage Δ | | |---|---|---| | [pkg/sync/common/types.go](https://app.codecov.io/gh/argoproj/gitops-engine/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL3N5bmMvY29tbW9uL3R5cGVzLmdv) | `50.00% <0.00%> (-4.17%)` | :arrow_down: | | [pkg/sync/sync\_context.go](https://app.codecov.io/gh/argoproj/gitops-engine/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL3N5bmMvc3luY19jb250ZXh0Lmdv) | `72.83% <20.00%> (-1.25%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cenk1cenk2 commented 6 months ago

This would be a great addition when using with operators that return some actual warnings.