argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.69k stars 259 forks source link

feat: sync-options annotation with Force=true (#414) #560

Closed kkk777-7 closed 6 months ago

kkk777-7 commented 11 months ago

This PR implements #414, https://github.com/argoproj/argo-cd/issues/5882

Changes:

Related: https://github.com/argoproj/gitops-engine/pull/526

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.66%. Comparing base (5fd9f44) to head (bba3871). Report is 2 commits behind head on master.

:exclamation: Current head bba3871 differs from pull request most recent head a463a21. Consider uploading reports for the commit a463a21 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #560 +/- ## ========================================== - Coverage 54.71% 54.66% -0.05% ========================================== Files 41 41 Lines 4834 4648 -186 ========================================== - Hits 2645 2541 -104 + Misses 1977 1910 -67 + Partials 212 197 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
27.5% 27.5% Duplication

jmgilman commented 9 months ago

Any chance this can get merged soon?

douglasday commented 8 months ago

Also interested in seeing this merged

faust64 commented 8 months ago

It's now been almost two years since we're waiting for that fix ( https://github.com/argoproj/gitops-engine/issues/414 ) Is there anyone to review that PR?!

@alexec @alexmt @jannfis @jessesuen @mayzhang2000 ?

pasha-codefresh commented 6 months ago

@kkk777-7 , i am really sorry for long review on it, could you please solve conflicts ?

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.5% Duplication on New Code

See analysis details on SonarCloud

kkk777-7 commented 6 months ago

@pasha-codefresh , thank you reply! I resolved conflict.