fix: temporary files written to '/dev/shm' not cleaned up (#568)

argoproj / gitops-engine

Democratizing GitOps

https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories

Apache License 2.0

1.7k stars 265 forks source link

fix: temporary files written to '/dev/shm' not cleaned up (#568) #569

Closed jgwest closed 7 months ago

jgwest commented 7 months ago

Fixes #568

See parent issue for details of the problem

This PR:

ctl.go: Adds a call to DeleteFile to handle the (rare) case where WriteKubeConfig fails.
resource_ops.go: Moves defer io.DeleteFile(...) call to handle the (rare) case where Write or Close fail.

Admittedly, these are likely to be rare: it's unlikely that writing to a file would fail, when that file was already successfully created earlier in the function.

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud