Open tosi3k opened 1 month ago
@crenshaw-dev thanks for the review - I'll respond to the comments here later on.
FWIW as agreed offline during yesterday's sync, I split the fix into two PRs - this one would just drop unnecessary listing after watch expiry and https://github.com/argoproj/gitops-engine/pull/617 would make the list API calls target the watch cache instead of etcd.
I guess we can proceed with the latter one.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This LGTM from k8s perspective.
This change addresses the performance issue existing in the cluster cache described in https://github.com/argoproj/argo-cd/issues/18838.
kube-apiserver
logs for the Pods resource (supposed super-low latency logged for the WATCH requests is due to a bug in Kubernetes: https://github.com/kubernetes/kubernetes/issues/125614):