argoproj / gitops-engine

Democratizing GitOps
https://pkg.go.dev/github.com/argoproj/gitops-engine?tab=subdirectories
Apache License 2.0
1.7k stars 264 forks source link

fix: health hpa when only second conditions is False #624

Open afarbos opened 2 months ago

afarbos commented 2 months ago

Currently the health check return healthy if the first conditions is healthy.

This fix, first verify all conditions are healthy before returning healthy, allowing to catch when the first conditions is healthy but not the second.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud