chore(deps): upgrade go version in dockerfile

jmeridth commented 1 week ago

Changes

I noticed the version difference between the go.mod and Dockerfile in the repo (1.17 vs 1.22). Fixed a few other things also, like upgrading the version of the alpine/git image to the latest version.

[x] fix warnings about case of as to AS in Dockerfile
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
[x] update Dockerfile Go version from 1.17 to 1.22 to match go.mod
[x] upgrade alipine/git image version to latest, current was 4 years old
- -from alpine/git:v2.24.3 (4 years old) to alpine/git:v2.45.2
[x] fix warning with linting happening in current ci runs
- WARN [config_reader] The configuration option 'run.skip-files' is deprecated, please use 'issues.exclude-files'
[x] add .tool-versions (asdf) to .gitignore

Tests

Test pass locally. No new features really added so unsure if new tests are needed.

Questions

Do I need to run this against an argo-cd instance or with argo-cd test suite to ensure we're good?

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jmeridth commented 1 week ago

Merging https://github.com/argoproj/gitops-engine/pull/639 first will fix the tar errors in the CI run with these changes (bottom of page).

jmeridth commented 5 days ago

Going to create argo-cd draft PR that uses these changes. Especially to test the git version update (2.24.3 -> 2.45.2)

rumstead commented 15 hours ago

Going to create argo-cd draft PR that uses these changes. Especially to test the git version update (2.24.3 -> 2.45.2)

Can you link the draft PR so we can see the argo-cd build passing?

argoproj / gitops-engine