Closed carloscastrojumo closed 4 months ago
Attention: Patch coverage is 26.66667%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 55.35%. Comparing base (
ec7fcb4
) to head (69e2e96
).
Files | Patch % | Lines |
---|---|---|
pkg/services/github.go | 26.66% | 9 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you, could you please update documentation about this option? Also could you please add test for this parameter ?
@carloscastrojumo
Hi @pasha-codefresh . I have updated the documentation about this option. Regarding the test for this parameter, I have included in the TestGetTemplater_GitHub_Deployment
test.
To actually test the send message, it requires some mock setup that is currently not defined yet and Im afraid Im not enough go test knowledge to implement the skeleton.
@pasha-codefresh any news on this please?
Sorry @carloscastrojumo , could you please fix conflicts and i will merge it
Done @pasha-codefresh :)
Thank you!
As it is, the
revision
that triggered the deployment is used as theref
, however it is useful to override so we can pass a tag, a branch or a different SHA.Example: