argoproj / notifications-engine

Affordable notifications for Kubernetes
Apache License 2.0
264 stars 134 forks source link

fix duplicate when using self-service #227

Closed mayzhang2000 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (c7e26ba) 53.93% compared to head (b16fe9c) 53.76%.

:exclamation: Current head b16fe9c differs from pull request most recent head 65cf3f2. Consider uploading reports for the commit 65cf3f2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #227 +/- ## ========================================== - Coverage 53.93% 53.76% -0.18% ========================================== Files 35 35 Lines 3278 3307 +29 ========================================== + Hits 1768 1778 +10 - Misses 1250 1265 +15 - Partials 260 264 +4 ``` | [Files](https://app.codecov.io/gh/argoproj/notifications-engine/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj) | Coverage Δ | | |---|---|---| | [pkg/api/config.go](https://app.codecov.io/gh/argoproj/notifications-engine/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL2FwaS9jb25maWcuZ28=) | `51.42% <ø> (ø)` | | | [pkg/controller/state.go](https://app.codecov.io/gh/argoproj/notifications-engine/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL2NvbnRyb2xsZXIvc3RhdGUuZ28=) | `90.00% <100.00%> (+0.76%)` | :arrow_up: | | [pkg/api/api.go](https://app.codecov.io/gh/argoproj/notifications-engine/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL2FwaS9hcGkuZ28=) | `52.17% <0.00%> (-2.38%)` | :arrow_down: | | [pkg/api/factory.go](https://app.codecov.io/gh/argoproj/notifications-engine/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL2FwaS9mYWN0b3J5Lmdv) | `53.22% <0.00%> (-1.32%)` | :arrow_down: | | [pkg/controller/controller.go](https://app.codecov.io/gh/argoproj/notifications-engine/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL2NvbnRyb2xsZXIvY29udHJvbGxlci5nbw==) | `64.45% <39.13%> (-3.06%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.