search

argoproj / notifications-engine

Affordable notifications for Kubernetes
Apache License 2.0
264 stars 134 forks source link

fix: issue-3044 add retries to webhook #236

Closed premadk closed 8 months ago

premadk commented 8 months ago

fixes: https://github.com/argoproj/argo-rollouts/issues/3044

codecov[bot] commented 8 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b3e6b6a) 54.76% compared to head (3a0b7ee) 55.13%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #236 +/- ## ========================================== + Coverage 54.76% 55.13% +0.37% ========================================== Files 35 35 Lines 3316 3337 +21 ========================================== + Hits 1816 1840 +24 + Misses 1232 1230 -2 + Partials 268 267 -1 ``` | [Files](https://app.codecov.io/gh/argoproj/notifications-engine/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj) | Coverage Δ | | |---|---|---| | [pkg/services/webhook.go](https://app.codecov.io/gh/argoproj/notifications-engine/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL3NlcnZpY2VzL3dlYmhvb2suZ28=) | `76.69% <100.00%> (+7.73%)` | :arrow_up: | | [pkg/triggers/service.go](https://app.codecov.io/gh/argoproj/notifications-engine/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argoproj#diff-cGtnL3RyaWdnZXJzL3NlcnZpY2UuZ28=) | `68.96% <72.72%> (+2.92%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zachaller commented 8 months ago

Can we get a bit of documentation on the new feature added: https://github.com/argoproj/notifications-engine/blob/master/docs/services/webhook.md