search

argoproj / notifications-engine

Affordable notifications for Kubernetes
Apache License 2.0
264 stars 134 forks source link

docs: Fix case of vendor names #240

Closed adamdmharvey closed 6 months ago

adamdmharvey commented 8 months ago

This PR fixes the case of two vendor names - PagerDuty and Opsgenie - in the docs just to make sure they're formal and aligned to those vendor's branding.

These don't look to be autogenerated in this repo, but best I understand get defined here and "pulled down" into CD and Rollouts?

This should help support upstream doc fix in https://github.com/argoproj/argo-cd/pull/16233. May require downstream PRs in both Argo CD and Argo Rollouts, lest the codegen steps in those fail (?).

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a8d185e) 55.13% compared to head (ab0b834) 55.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #240 +/- ## ======================================= Coverage 55.13% 55.13% ======================================= Files 35 35 Lines 3337 3337 ======================================= Hits 1840 1840 Misses 1230 1230 Partials 267 267 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.