Closed adamdmharvey closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
85c76ec
) 55.16% compared to head (9a49e81
) 55.16%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Noticed the last few CI runs went red; two from Dependabot. Tried a CI Lint local and all is clean for me...
docker run -t --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.53.3 golangci-lint run -v
INFO [config_reader] Config search paths: [./ /app / /root]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 8 linters: [errcheck goimports gosimple govet ineffassign staticcheck typecheck unused]
INFO [loader] Go packages loading at mode 575 (deps|imports|name|types_sizes|compiled_files|exports_file|files) took 24.919385803s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 14.731875ms
INFO [linters_context/goanalysis] analyzers took 1m24.572336731s with top 10 stages: buildir: 1m11.790198718s, inspect: 1.937708359s, nilness: 1.8296928s, fact_deprecated: 1.491018467s, ctrlflow: 1.155488234s, printf: 1.085978954s, fact_purity: 1.036888009s, typedness: 747.558529ms, SA5012: 476.053617ms, goimports: 346.929502ms
INFO [runner] Issues before processing: 12, after processing: 0
INFO [runner] Processors filtering stat (out/in): cgo: 12/12, autogenerated_exclude: 8/12, path_prettifier: 12/12, identifier_marker: 8/8, skip_files: 12/12, skip_dirs: 12/12, exclude: 8/8, exclude-rules: 0/8, filename_unadjuster: 12/12
INFO [runner] processing took 1.171956ms with stages: autogenerated_exclude: 572.625µs, path_prettifier: 419.209µs, identifier_marker: 95.416µs, skip_dirs: 46.249µs, exclude-rules: 27.083µs, cgo: 4.416µs, exclude: 1.582µs, filename_unadjuster: 1.251µs, nolint: 1.167µs, max_same_issues: 500ns, uniq_by_line: 416ns, fixer: 375ns, max_from_linter: 250ns, skip_files: 250ns, source_code: 209ns, path_shortener: 209ns, severity-rules: 208ns, sort_results: 208ns, diff: 208ns, max_per_file_from_linter: 83ns, path_prefixer: 42ns
INFO [runner] linters took 13.086596173s with stages: goanalysis_metalinter: 13.08531209s
INFO File cache stats: 0 entries of total size 0B
INFO Memory: 376 samples, avg is 445.5MB, max is 2367.3MB
INFO Execution took 38.026696684s
Minor wording improvement to help support https://github.com/argoproj/argo-cd/pull/16233. Include proper casing of a vendor name.