search

argoproj / notifications-engine

Affordable notifications for Kubernetes
Apache License 2.0
271 stars 147 forks source link

fix(ci): Download Go modules before linting to resolve TypeCheck errors #257

Open adamdmharvey opened 8 months ago

adamdmharvey commented 8 months ago

Noticed some reports on TypeCheck errors in https://github.com/golangci/golangci-lint-action/issues/902. These are similar to what we see with https://github.com/argoproj/notifications-engine/pull/256, https://github.com/argoproj/notifications-engine/pull/255, and https://github.com/argoproj/notifications-engine/pull/254.

The linter in v1.54 seemed to deprecate some of the TypeChecking errors, and so I've bumped the linter up also (which seemed to fix the problem).

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c02dc5f) 55.13% compared to head (2779b52) 55.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #257 +/- ## ======================================= Coverage 55.13% 55.13% ======================================= Files 35 35 Lines 3337 3337 ======================================= Hits 1840 1840 Misses 1230 1230 Partials 267 267 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pasha-codefresh commented 8 months ago

Looks like it is working now, should we close the PR?