search

argoproj / notifications-engine

Affordable notifications for Kubernetes
Apache License 2.0
264 stars 134 forks source link

feat(opsgenie): Add support for setting priority in Opsgenie notification #267

Closed bofaalsarah closed 5 months ago

bofaalsarah commented 5 months ago

This PR adds support for setting the priority field in Opsgenie notifications. If a priority is provided in the notification, it will be included in the alert creation request to Opsgenie. Additionally, the code now checks for missing description in Opsgenie notifications and returns an error if it's missing.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c0913e2) 54.79% compared to head (1b66450) 54.99%.

Files Patch % Lines
pkg/services/opsgenie.go 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #267 +/- ## ========================================== + Coverage 54.79% 54.99% +0.19% ========================================== Files 35 35 Lines 3376 3386 +10 ========================================== + Hits 1850 1862 +12 + Misses 1254 1251 -3 - Partials 272 273 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pasha-codefresh commented 5 months ago

Thank you @bofaalsarah , could you please add test for it ?

bofaalsarah commented 5 months ago

Thank you @bofaalsarah , could you please add test for it ?

Done ✅

pasha-codefresh commented 5 months ago

LGTM, thank you

pasha-codefresh commented 5 months ago

@bofaalsarah only one thing, could you please add some documentation about it? it can be dedicated PR

bofaalsarah commented 5 months ago

Sure, I will create another PR for the documentation