argoproj / notifications-engine

Affordable notifications for Kubernetes
Apache License 2.0
264 stars 134 forks source link

feat(opsgenie): Add support for setting alias in Opsgenie notification #268

Closed gazidizdaroglu closed 4 months ago

gazidizdaroglu commented 5 months ago

This PR adds support for setting the alias field in the Opsgenie notifications.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (4222fe0) 54.99% compared to head (0803b19) 55.14%.

Files Patch % Lines
pkg/services/opsgenie.go 42.85% 7 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #268 +/- ## ========================================== + Coverage 54.99% 55.14% +0.15% ========================================== Files 35 35 Lines 3386 3400 +14 ========================================== + Hits 1862 1875 +13 Misses 1251 1251 - Partials 273 274 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pasha-codefresh commented 4 months ago

@gazidizdaroglu Great job, could you please add this parameter description to documentation ?

gazidizdaroglu commented 4 months ago

@pasha-codefresh sure, let me update the documentation

gazidizdaroglu commented 4 months ago

@pasha-codefresh I've updated the doc

pasha-codefresh commented 4 months ago

Wow, amazing work, thank you