search

argoproj / notifications-engine

Affordable notifications for Kubernetes
Apache License 2.0
264 stars 134 forks source link

fix: Ignore 422 response while creating commit statuses #299

Open ragnarpa opened 1 month ago

ragnarpa commented 1 month ago

Ignore HTTP 422 responses by GitHub while trying to create commit statuses. GitHub limits creating commit statuses to 1000 attempts with the same SHA and context. Currently, when the limit is reached, Argo CD notification controller keeps retrying needlessly which wastes resources. Instead, the notification engine should give up on retrying and signal the caller that the notification attempt has been processed.

ragnarpa commented 1 month ago

@pasha-codefresh, can you review it?